Skip to content

Add all kernel breakpoints hit test #1453

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add all kernel breakpoints hit test #1453

wants to merge 1 commit into from

Conversation

ZzEeKkAa
Copy link
Contributor

@ZzEeKkAa ZzEeKkAa commented May 8, 2024 •
edited
Loading

Check that every thread in kernel hits breakpoint.

This test was not tested on GPU!

Closes #483

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • +/- Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • If this PR is a work in progress, are you filing the PR as a draft?

@ZzEeKkAa ZzEeKkAa requested a review from diptorupd May 8, 2024 15:57
@ZzEeKkAa ZzEeKkAa self-assigned this May 8, 2024
@coveralls
Copy link
Collaborator

coveralls commented May 8, 2024 •
edited
Loading

Coverage Status

coverage: 86.48%. remained the same
when pulling f701fb0 on testing/add_all_kernel_breakpoints_hit_test
into 574daab on main.

@diptorupd
Copy link
Contributor

@ZzEeKkAa if it works on CPU it is a good test to add. You can XFail on GPU.

@diptorupd diptorupd force-pushed the testing/add_all_kernel_breakpoints_hit_test branch from fff80fb to f701fb0 Compare May 10, 2024 16:03
@diptorupd diptorupd force-pushed the testing/add_all_kernel_breakpoints_hit_test branch from f701fb0 to a71c102 Compare May 15, 2024 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@diptorupd diptorupd Awaiting requested review from diptorupd

At least 1 approving review is required to merge this pull request.

Assignees

@ZzEeKkAa ZzEeKkAa

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

If a kernel is executed by multiple threads in parallel, see that debugger hits the breakpoint for each thread

3 participants

@ZzEeKkAa @coveralls @diptorupd